[webkit-reviews] review granted: [Bug 202142] Fix ServiceWorker downloads : [Attachment 446524] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 08:53:01 PST 2021


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 202142: Fix ServiceWorker downloads
https://bugs.webkit.org/show_bug.cgi?id=202142

Attachment 446524: Patch

https://bugs.webkit.org/attachment.cgi?id=446524&action=review




--- Comment #51 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 446524
  --> https://bugs.webkit.org/attachment.cgi?id=446524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446524&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:63
> +}

maybe call close here to unregister if we haven't already?

>
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.h:3
0
> +#include  "DownloadID.h"

nit: extra space


More information about the webkit-reviews mailing list