[webkit-reviews] review granted: [Bug 231009] Cocoa WebGL should support UI side compositing : [Attachment 446730] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 231009: Cocoa WebGL should support UI side compositing
https://bugs.webkit.org/show_bug.cgi?id=231009

Attachment 446730: Patch

https://bugs.webkit.org/attachment.cgi?id=446730&action=review




--- Comment #46 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 446730
  --> https://bugs.webkit.org/attachment.cgi?id=446730
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446730&action=review

> Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm:89
> +    const bool m_isOpaque;
> +    const float m_contentsScale;
> +    std::unique_ptr<IOSurface> m_displayBuffer;

Doesn't really matter but I would flip the ordering to avoid padding.

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:140
> +    // FIXME: This should be removed and m_bufferHandle should be used to
ref the buffer once ShareableBitmap::Handle
> +    // can be encoded multiple times.

File a bug to track?

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:117
> +    // FIXME: For simplicity this should be moved to the end of display()
once the buffer handles can be created once
> +    // and stored in m_bufferHandle.

Reference the same bug.

>
Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.m
m:91
> +    const bool m_isOpaque;
> +    const float m_contentsScale;
> +    MachSendRight m_displayBuffer;

Ditto.