[webkit-reviews] review granted: [Bug 234149] Log that AudioMediaStreamTrackRendererInternalUnitManager::Proxy::reset is called : [Attachment 446725] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 08:21:09 PST 2021


Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 234149: Log that
AudioMediaStreamTrackRendererInternalUnitManager::Proxy::reset is called
https://bugs.webkit.org/show_bug.cgi?id=234149

Attachment 446725: Patch

https://bugs.webkit.org/attachment.cgi?id=446725&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 446725
  --> https://bugs.webkit.org/attachment.cgi?id=446725
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446725&action=review

>
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitMa
nager.cpp:274
> +    RELEASE_LOG_ERROR(WebRTC,
"AudioMediaStreamTrackRendererInternalUnitManager::Proxy::reset %d", isClosed
== IsClosed::Yes);

Do you mean to log this as an error?


More information about the webkit-reviews mailing list