[webkit-reviews] review granted: [Bug 234110] [LFC][IFC] Replace Vector<std::unique_ptr<DisplayBoxNode> with Vector<DisplayBoxTree::Node> : [Attachment 446627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 06:05:57 PST 2021


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 234110: [LFC][IFC] Replace Vector<std::unique_ptr<DisplayBoxNode> with
Vector<DisplayBoxTree::Node>
https://bugs.webkit.org/show_bug.cgi?id=234110

Attachment 446627: Patch

https://bugs.webkit.org/attachment.cgi?id=446627&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 446627
  --> https://bugs.webkit.org/attachment.cgi?id=446627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446627&action=review

>
Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
:347
> +	   // Node index in m_displayBoxNodes.
> +	   size_t thisIndex { 0 };

This doesn't appear to be used.


More information about the webkit-reviews mailing list