[webkit-reviews] review granted: [Bug 233863] [LBSE] Begin layer-aware RenderSVGRoot implementation : [Attachment 446165] Patch, v5

[bugzilla-daemon at webkit.org]

Rob Buis <rbuis at igalia.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 233863: [LBSE] Begin layer-aware RenderSVGRoot implementation
https://bugs.webkit.org/show_bug.cgi?id=233863

Attachment 446165: Patch, v5

https://bugs.webkit.org/attachment.cgi?id=446165&action=review




--- Comment #14 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 446165
  --> https://bugs.webkit.org/attachment.cgi?id=446165
Patch, v5

View in context: https://bugs.webkit.org/attachment.cgi?id=446165&action=review

>>> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:246
>>> +	 return effectiveOverflowX() == Overflow::Hidden
>> 
>> The effectiveOverflowX makes only sense when compared with visible IIRC. I
guess the question is what to do here for overflow:clip or it being enabled due
to contain: paint.
> 
> I followed your change in LegacyRenderSVGRoot from Nov 16.
> 
> 5ed3c610d08e7 Source/WebCore/rendering/svg/RenderSVGRoot.cpp	     (Rob Buis 
	    2021-11-16 22:32:39 +0000 218)     return effectiveOverflowX() ==
Overflow::Hidden
> 
> commit 5ed3c610d08e786fec6b85e6137676ce89002aed
> Author: Rob Buis <rbuis at igalia.com>
> Date:   Tue Nov 16 22:32:39 2021 +0000
> 
>     [css-contain] Support contain:paint
>     https://bugs.webkit.org/show_bug.cgi?id=224742
> 
> There you specifically moved to check effectiveOverflowX() ==
Overflow::Hidden for (Legacy)RenderSVGRoot. You have to clarify if that's
correct wrt to contain: paint ;-)

Ok, then it must be right :)