[webkit-reviews] review granted: [Bug 234108] [GPU Process] [Filters] Make FilterEffectVector a Vector of Ref<FilterEffect> : [Attachment 446667] Patch

[bugzilla-daemon at webkit.org]

Cameron McCormack (:heycam) <heycam at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 234108: [GPU Process] [Filters] Make FilterEffectVector a Vector of
Ref<FilterEffect>
https://bugs.webkit.org/show_bug.cgi?id=234108

Attachment 446667: Patch

https://bugs.webkit.org/attachment.cgi?id=446667&action=review




--- Comment #2 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 446667
  --> https://bugs.webkit.org/attachment.cgi?id=446667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446667&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:150
>  FilterEffect* FilterEffect::inputEffect(unsigned number) const

Should this be changed to return a reference too?