[webkit-reviews] review granted: [Bug 233369] Web Inspector: Extract a specialized CSSNameCompletions from CSSCompletions : [Attachment 446530] Patch 1.2

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Razvan Caliman
<rcaliman at apple.com>'s request for review:
Bug 233369: Web Inspector: Extract a specialized CSSNameCompletions from
CSSCompletions
https://bugs.webkit.org/show_bug.cgi?id=233369

Attachment 446530: Patch 1.2

https://bugs.webkit.org/attachment.cgi?id=446530&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 446530
  --> https://bugs.webkit.org/attachment.cgi?id=446530
Patch 1.2

View in context: https://bugs.webkit.org/attachment.cgi?id=446530&action=review

r=me, neato :)

> Source/WebInspectorUI/UserInterface/Models/CSSPropertyNameCompletions.js:28
> +    constructor(properties, {acceptEmptyPrefix} = {})

NIT: since `acceptEmptyPrefix` isn't used here, i'd make this into an `options
= {}` so that if new things are added to `WI.CSSCompletions` in the future you
don't have to also update this