[webkit-reviews] review granted: [Bug 234013] Add a new WKWebpagePreferences SPI for modal container observation policies : [Attachment 446390] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 234013: Add a new WKWebpagePreferences SPI for modal container observation
policies
https://bugs.webkit.org/show_bug.cgi?id=234013

Attachment 446390: Patch

https://bugs.webkit.org/attachment.cgi?id=446390&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 446390
  --> https://bugs.webkit.org/attachment.cgi?id=446390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446390&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:466
> +	  
_websitePolicies->setModalContainerObservationPolicy(WebCore::ModalContainerObs
ervationPolicy::Disabled);

It really seems silly to require these adaptor methods for these equivalent
enums, but I realize that's just the way this stuff is designed.