[webkit-reviews] review granted: [Bug 234017] [iOS] Add SPI to enable find interactions on WKWebView : [Attachment 446392] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 234017: [iOS] Add SPI to enable find interactions on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=234017

Attachment 446392: Patch

https://bugs.webkit.org/attachment.cgi?id=446392&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 446392
  --> https://bugs.webkit.org/attachment.cgi?id=446392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446392&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:445
> + at property (nonatomic, readwrite, setter=_setFindInteractionEnabled:) BOOL
_findInteractionEnabled WK_API_AVAILABLE(ios(WK_IOS_TBA));

There was some discussion about whether this should be here (on WKWebView) or
WKPreferences.

We (Geoff, Tim, Aditya, Alex and I) chatted about this over Slack, and I
*think* we all eventually came to the conclusion that this property should go
on WKWebView itself, since setting this has side effects beyond just changing
the value of a flag (and so calling `-_setFindInteractionEnabled:` is, in a
way, performing an action on the web view).

If it were only changing the flag's value, then I think we would put this on
WKPreferences, like most of the other API/SPI flags.