[webkit-reviews] review granted: [Bug 234022] Prepare for transition to C++20 : [Attachment 446455] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 9 14:38:28 PST 2021
Yusuke Suzuki <ysuzuki at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 234022: Prepare for transition to C++20
https://bugs.webkit.org/show_bug.cgi?id=234022
Attachment 446455: Patch
https://bugs.webkit.org/attachment.cgi?id=446455&action=review
--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 446455
--> https://bugs.webkit.org/attachment.cgi?id=446455
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=446455&action=review
r=me with one fix.
> Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:-297
> - NonCopyable(NonCopyable&&) = default;
> - NonCopyable(const NonCopyable&) = delete;
> - NonCopyable& operator=(const NonCopyable&) = delete;
> - NonCopyable& operator=(NonCopyable&&) = default;
We should use `WTF_MAKE_NONCOPYABLE` here to make it noncopyable.
More information about the webkit-reviews
mailing list