[webkit-reviews] review granted: [Bug 233989] [GPU Process] [Filters] Enable Filter rendering in GPU Process : [Attachment 446597] Patch

[bugzilla-daemon at webkit.org]

Cameron McCormack (:heycam) <heycam at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 233989: [GPU Process] [Filters] Enable Filter rendering in GPU Process
https://bugs.webkit.org/show_bug.cgi?id=233989

Attachment 446597: Patch

https://bugs.webkit.org/attachment.cgi?id=446597&action=review




--- Comment #6 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 446597
  --> https://bugs.webkit.org/attachment.cgi?id=446597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446597&action=review

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:157
> +    auto hostWindow = renderer.view().frameView().root() ?
renderer.view().frameView().root()->hostWindow() : nullptr;

(I see this fragment so often that I wonder if createImageBuffer functions
should take the renderer as an argument instead of the host window.)