[webkit-reviews] review requested: [Bug 233372] Web Inspector: Add CSS variable names to property name completion list : [Attachment 446599] Patch 1.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 13:22:35 PST 2021


Razvan Caliman <rcaliman at apple.com> has asked  for review:
Bug 233372: Web Inspector: Add CSS variable names to property name completion
list
https://bugs.webkit.org/show_bug.cgi?id=233372

Attachment 446599: Patch 1.1

https://bugs.webkit.org/attachment.cgi?id=446599&action=review




--- Comment #5 from Razvan Caliman <rcaliman at apple.com> ---
Created attachment 446599

  --> https://bugs.webkit.org/attachment.cgi?id=446599&action=review

Patch 1.1

Address code review feedback:
- update name of flag for indicating list of css variables is out of date
- avoid copying arrays with Array.concat()

Depends on Bug 233369


More information about the webkit-reviews mailing list