[webkit-reviews] review granted: [Bug 234089] Get Markup Pane to display and in the proper location. : [Attachment 446573] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 234089: Get Markup Pane to display and in the proper location.
https://bugs.webkit.org/show_bug.cgi?id=234089

Attachment 446573: Patch

https://bugs.webkit.org/attachment.cgi?id=446573&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 446573
  --> https://bugs.webkit.org/attachment.cgi?id=446573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446573&action=review

> Source/WebCore/ChangeLog:3
> +	   Get Markup Pane to display and in the proper location.

Title should describe the problem, not the fix

> Source/WebKit/Shared/ContextMenuContextData.cpp:74
> +    , m_controlledImageFrame(imageRect)

I know I said frame, but maybe go with "bounds"?

> Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:243
> +    auto webView = m_webView.get();

What is this about? you can just m_webView in all the places below.