[webkit-reviews] review granted: [Bug 233880] [LFC][IFC] Refactor bidi inline box boundary handling : [Attachment 446373] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 08:17:05 PST 2021

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 233880: [LFC][IFC] Refactor bidi inline box boundary handling

Attachment 446373: Patch


--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 446373
  --> https://bugs.webkit.org/attachment.cgi?id=446373

View in context: https://bugs.webkit.org/attachment.cgi?id=446373&action=review

> Source/WebCore/ChangeLog:13
> +	     the previous ends +-horizontal margins) unless the content is
embedded in an inline box (e.g. <span>embedded content</soan>)


> +    Vector<std::unique_ptr<DisplayBoxNode>> children;

I think we could reduce heap allocation by making this Vector<DisplayBoxNode>
(with some inline capacity perhaps).

> +    Vector<DisplayBoxNode*> m_stack;

Then this would probably need to be replaced with some sort of index thing.

More information about the webkit-reviews mailing list