[webkit-reviews] review granted: [Bug 233880] [LFC][IFC] Refactor bidi inline box boundary handling : [Attachment 446373] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 233880: [LFC][IFC] Refactor bidi inline box boundary handling
https://bugs.webkit.org/show_bug.cgi?id=233880

Attachment 446373: Patch

https://bugs.webkit.org/attachment.cgi?id=446373&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 446373
  --> https://bugs.webkit.org/attachment.cgi?id=446373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446373&action=review

> Source/WebCore/ChangeLog:13
> +	     the previous ends +-horizontal margins) unless the content is
embedded in an inline box (e.g. <span>embedded content</soan>)

</span>

>
Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
:345
> +    Vector<std::unique_ptr<DisplayBoxNode>> children;

I think we could reduce heap allocation by making this Vector<DisplayBoxNode>
(with some inline capacity perhaps).

>
Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
:371
> +    Vector<DisplayBoxNode*> m_stack;

Then this would probably need to be replaced with some sort of index thing.