[webkit-reviews] review granted: [Bug 233911] CSP: Allow external scripts with SRI hashes matching CSP : [Attachment 446274] Patch

[bugzilla-daemon at webkit.org]

Kate Cheney <katherine_cheney at apple.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 233911: CSP: Allow external scripts with SRI hashes matching CSP
https://bugs.webkit.org/show_bug.cgi?id=233911

Attachment 446274: Patch

https://bugs.webkit.org/attachment.cgi?id=446274&action=review




--- Comment #8 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 446274
  --> https://bugs.webkit.org/attachment.cgi?id=446274
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446274&action=review

> Source/WebCore/loader/ResourceCryptographicDigest.cpp:74
> +    if (auto digest = base64Decode(hashValue))

A bit strange that some hash digests in wpt tests don't have correct padding.