[webkit-reviews] review granted: [Bug 233940] Allow `Pasteboard::readBuffer` to read from the pasteboard as a whole instead of a specific item : [Attachment 446235] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 22:16:03 PST 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 233940: Allow `Pasteboard::readBuffer` to read from the pasteboard as a
whole instead of a specific item
https://bugs.webkit.org/show_bug.cgi?id=233940

Attachment 446235: Patch

https://bugs.webkit.org/attachment.cgi?id=446235&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 446235
  --> https://bugs.webkit.org/attachment.cgi?id=446235
Patch

(In reply to Devin Rousso from comment #5)
> actually, this might be necessary

It's not really clear from the ChangeLog (or the comments) why this is the
case, but it does seem like a fairly straightforward refactoring. I would've
thought that simply reading the item at index 0 (or none if there are no items)
would achieve the same thing.


More information about the webkit-reviews mailing list