[webkit-reviews] review granted: [Bug 233976] Assert isMainThread() in hasValidAverageCharWidth : [Attachment 446298] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 21:05:08 PST 2021


Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 233976: Assert isMainThread() in hasValidAverageCharWidth
https://bugs.webkit.org/show_bug.cgi?id=233976

Attachment 446298: Patch

https://bugs.webkit.org/attachment.cgi?id=446298&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 446298
  --> https://bugs.webkit.org/attachment.cgi?id=446298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446298&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:344
> +    ASSERT(isMainThread());

This is fine, but why not any of the other functions in FontCascade?


More information about the webkit-reviews mailing list