[webkit-reviews] review granted: [Bug 234056] Use thread safe initialization for statics in Font::getCFStringAttributes : [Attachment 446476] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 234056: Use thread safe initialization for statics in
Font::getCFStringAttributes
https://bugs.webkit.org/show_bug.cgi?id=234056

Attachment 446476: Patch

https://bugs.webkit.org/attachment.cgi?id=446476&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 446476
  --> https://bugs.webkit.org/attachment.cgi?id=446476
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446476&action=review

> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:46
> +static CFNumberRef zeroKerningValue()

This function just returns a float zero. I don’t think its name should include
"kerning value". It can be reused by anyone who needs a 0.0f as a CFNumber.