[webkit-reviews] review granted: [Bug 234037] Refactoring: Make MediaPlayerEnums and HTMLMediaElementEnums namespaces rather than classes : [Attachment 446434] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 234037: Refactoring: Make MediaPlayerEnums and HTMLMediaElementEnums
namespaces rather than classes
https://bugs.webkit.org/show_bug.cgi?id=234037

Attachment 446434: Patch

https://bugs.webkit.org/attachment.cgi?id=446434&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 446434
  --> https://bugs.webkit.org/attachment.cgi?id=446434
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446434&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:1323
> -	   m_networkState = NETWORK_LOADING;
> +	   m_networkState = NetworkState::Idle;

This seems wrong.

> Source/WebCore/html/HTMLMediaElement.cpp:1460
> -    m_networkState = NETWORK_LOADING;
> +    m_networkState = NetworkState::Idle;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:2320
> -	   if (m_networkState < NETWORK_LOADING || m_networkState ==
NETWORK_NO_SOURCE)
> +	   if (m_networkState < NetworkState::Idle || m_networkState ==
NetworkState::NoSource)

Ditto.

> Source/WebCore/html/HTMLMediaElement.cpp:2322
> -	   m_networkState = NETWORK_LOADING;
> +	   m_networkState = NetworkState::Idle;

Ditto.

> Source/WebCore/html/HTMLMediaElement.cpp:2918
> -    if (m_networkState != NETWORK_LOADING)
> +    if (m_networkState != NetworkState::Idle)

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:3928
> -    return !paused() && m_networkState == NETWORK_LOADING && m_readyState <=
HAVE_CURRENT_DATA;
> +    return !paused() && m_networkState == NetworkState::Idle && m_readyState
<= ReadyState::HaveCurrentData;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:3943
> -    return !paused() && m_networkState == NETWORK_LOADING && m_readyState <=
HAVE_CURRENT_DATA && m_sentStalledEvent;
> +    return !paused() && m_networkState == NetworkState::Idle && m_readyState
<= ReadyState::HaveCurrentData && m_sentStalledEvent;

Ditto

> Source/WebCore/html/HTMLMediaElement.cpp:4932
> -    m_networkState = NETWORK_LOADING;
> +    m_networkState = NetworkState::Idle;

Ditto.

> Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.h:84
> +	   MediaPlayerEnums::VideoFullscreenMode mode() const { return m_mode;
}

Nit: extra indentation