[webkit-reviews] review requested: [Bug 233369] Web Inspector: Extract a specialized CSSNameCompletions from CSSCompletions : [Attachment 446418] Patch 1.1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 8 13:53:22 PST 2021
Razvan Caliman <rcaliman at apple.com> has asked for review:
Bug 233369: Web Inspector: Extract a specialized CSSNameCompletions from
CSSCompletions
https://bugs.webkit.org/show_bug.cgi?id=233369
Attachment 446418: Patch 1.1
https://bugs.webkit.org/attachment.cgi?id=446418&action=review
--- Comment #4 from Razvan Caliman <rcaliman at apple.com> ---
Created attachment 446418
--> https://bugs.webkit.org/attachment.cgi?id=446418&action=review
Patch 1.1
Address code review feedback:
- renamed CSSNameCompletions to CSSPropertyNameCompletions
- added accessor WI.cssManager.propertyNameCompletions
- updated callsites
- updated contents of initializeCSSPropertyNameCompletions(target) to use
contemporary JS
- updated signature of CSSCompletions to expect an object instead of a list of
arguments
More information about the webkit-reviews
mailing list