[webkit-reviews] review granted: [Bug 234026] [MSE] Add a Modules/mediasource/README.md file : [Attachment 446404] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 234026: [MSE] Add a Modules/mediasource/README.md file
https://bugs.webkit.org/show_bug.cgi?id=234026

Attachment 446404: Patch

https://bugs.webkit.org/attachment.cgi?id=446404&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 446404
  --> https://bugs.webkit.org/attachment.cgi?id=446404
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446404&action=review

> Source/WebCore/Modules/mediasource/README.md:7
> +The Media Source Extensions specification defines a set of classes which
allows clients to implement their own loading, buffering, and variant switching
behavior, as opposed to allowing the UA to handle same.

Maybe "as opposed to requiring the UA to" instead of "allowing"?

> Source/WebCore/Modules/mediasource/README.md:59
> +MediaSample is an abstract base class representing a sample parsed from a
media segment. MediaSamples have `presentationTime()`, `decodeTime()`, and
`duration()`, which are used to order these samples relative to one another in
a [SampleMap](#samplemap). For codecs which support frame reordering,
`presentationTime()` and `decodeTime()` for each sample may differ.

It is probably worth mentioning `MediaTime`, and why we use it instead of
`double` for time values..