[webkit-reviews] review denied: [Bug 234007] [libpas] Fix up missing header includes and build guards in unit tests : [Attachment 446363] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 234007: [libpas] Fix up missing header includes and build guards in unit
tests
https://bugs.webkit.org/show_bug.cgi?id=234007

Attachment 446363: Patch

https://bugs.webkit.org/attachment.cgi?id=446363&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 446363
  --> https://bugs.webkit.org/attachment.cgi?id=446363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446363&action=review

> Source/bmalloc/libpas/src/test/IsoHeapChaosTests.cpp:622
> +#if PAS_OS(DARWIN)
>	       for (pthread_t thread : runningThreads) {
>		   kern_return_t result =
thread_suspend(pthread_mach_thread_np(thread));
>		   PAS_ASSERT(result == KERN_SUCCESS);
>	       }
> +#endif

If we cannot suspend and resume threads, then this test is broken. So you need
to disable this test for that platforms.