[webkit-reviews] review granted: [Bug 234021] [Win] WebCore::cfHDropFormat implementation is not CF specific : [Attachment 446389] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 234021: [Win] WebCore::cfHDropFormat implementation is not CF specific
https://bugs.webkit.org/show_bug.cgi?id=234021

Attachment 446389: Patch

https://bugs.webkit.org/attachment.cgi?id=446389&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 446389
  --> https://bugs.webkit.org/attachment.cgi?id=446389
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446389&action=review

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:49
>  FORMATETC* cfHDropFormat()

Could we rename these to things like "dropFormat"?

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:737
>  void getCFData(IDataObject* data, FORMATETC* format, Vector<String>&
dataStrings)

ditto

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:791
>  void setCFData(IDataObject* data, FORMATETC* format, const Vector<String>&
dataStrings)

ditto