[webkit-reviews] review granted: [Bug 234015] Propagate app-initiated state to new ResourceRequests : [Attachment 446382] WIP Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 10:48:35 PST 2021


Kate Cheney <katherine_cheney at apple.com> has granted  review:
Bug 234015: Propagate app-initiated state to new ResourceRequests
https://bugs.webkit.org/show_bug.cgi?id=234015

Attachment 446382: WIP Patch

https://bugs.webkit.org/attachment.cgi?id=446382&action=review




--- Comment #3 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 446382
  --> https://bugs.webkit.org/attachment.cgi?id=446382
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446382&action=review

Thanks for covering these cases. r=me with gtk/wpe/wincairo/win fixes.

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:97
> +    if (auto* documentLoader = m_document->loader())

Seems like you may need to #include DocumentLoader.h here for GTK and WPE.

> Source/WebCore/loader/FrameLoader.cpp:3058
> +    workingResourceRequest.setIsAppInitiated(inRequest.isAppInitiated());

We set this in updateRequestAndAddExtraFields which is called below, so no need
to do it here.


More information about the webkit-reviews mailing list