[webkit-reviews] review granted: [Bug 234002] Copy ServiceWorkerNavigationPreloader error when failing its ServiceWorkerFetchTask : [Attachment 446356] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 234002: Copy ServiceWorkerNavigationPreloader error when failing its
ServiceWorkerFetchTask
https://bugs.webkit.org/show_bug.cgi?id=234002

Attachment 446356: Patch

https://bugs.webkit.org/attachment.cgi?id=446356&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 446356
  --> https://bugs.webkit.org/attachment.cgi?id=446356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446356&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:370
>	   if (!m_preloader->error().isNull()) {

Maybe this would look better?
```
if (auto error = m_preloader->error(); !error.isNull()) {
    didFail(error);
    return;
}
```

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:397
> +	       didFail(ResourceError { m_preloader->error() });

ditto.