[webkit-reviews] review granted: [Bug 233994] GraphicsContextGLANGLE delivers context lost twice when reshape fails : [Attachment 446334] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 233994: GraphicsContextGLANGLE delivers context lost twice when reshape
fails
https://bugs.webkit.org/show_bug.cgi?id=233994

Attachment 446334: Patch

https://bugs.webkit.org/attachment.cgi?id=446334&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 446334
  --> https://bugs.webkit.org/attachment.cgi?id=446334
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446334&action=review

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:387
> +    // Returns true on success.
>      bool reshapeFBOs(const IntSize&);

enum class return type would requires less explanations

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:400
> -    // Returns false if context should be lost due to timeout.
> +    // Returns true on success. Returns false if context should be lost due
to timeout.
>      bool waitAndUpdateOldestFrame() WARN_UNUSED_RETURN;

here too