[webkit-reviews] review granted: [Bug 233957] [iOS] Add support for _UITextSearchOptions when finding a string : [Attachment 446250] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 233957: [iOS] Add support for _UITextSearchOptions when finding a string
https://bugs.webkit.org/show_bug.cgi?id=233957

Attachment 446250: Patch

https://bugs.webkit.org/attachment.cgi?id=446250&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 446250
  --> https://bugs.webkit.org/attachment.cgi?id=446250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446250&action=review

r=me! (assuming EWS is happy with this, after #233915 lands)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9970
> +	   findOptions.add(WebKit::FindOptions::AtWordStarts);
> +	   findOptions.add(WebKit::FindOptions::AtWordEnds);

Nit - I think you can just do `.add({ WebKit::FindOptions::AtWordStarts,
WebKit::FindOptions::AtWordEnds });` here.