[webkit-reviews] review granted: [Bug 233389] [WebAuthn] Consider support for the displayName for FIDO authenticator : [Attachment 446049] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 233389: [WebAuthn] Consider support for the displayName for FIDO
authenticator
https://bugs.webkit.org/show_bug.cgi?id=233389

Attachment 446049: Patch

https://bugs.webkit.org/attachment.cgi?id=446049&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 446049
  --> https://bugs.webkit.org/attachment.cgi?id=446049
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446049&action=review

> Source/WebKit/ChangeLog:9
> +	   Start storing the displayName and icon fields with the platform
authenticator

Are these part of the WebAuthn spec? If so, could you add comments in the code
indicating the relevant spec step to make it easy to find/validate this later?

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:271
> +	   [credential setDictionary:@{

Could also be done with 'initWithObjectsAndKeys: ', but I doubt there's any
real performance benefit to doing so.