[webkit-reviews] review granted: [Bug 233750] remove expandAroundIdeographs static variables : [Attachment 446238] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 233750: remove expandAroundIdeographs static variables
https://bugs.webkit.org/show_bug.cgi?id=233750

Attachment 446238: Patch

https://bugs.webkit.org/attachment.cgi?id=446238&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 446238
  --> https://bugs.webkit.org/attachment.cgi?id=446238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446238&action=review

Very excited!

> Source/WebCore/ChangeLog:14
> +	   With OffscreenCanvas, we can call into
> +	   ComplexTextController::adjustGlyphsAndAdvances,
> +	   FontCascade::expansionOpportunityCountInternal, and
> +	   WidthIterator::calculateAdditionalWidth from worker threads.
> +	   These all have a static variable variable with an initializer
> +	   that calls FontCascade::canExpandAroundIdeographsInComplexText,
> +	   and such initializers are not safe under -fno-threadsafe-statics.

This should probably be updated.