[webkit-reviews] review granted: [Bug 233935] [Cocoa] Web Inspector: provide a way for _WKInspectorExtension clients to be to notified when an extension tab navigates : [Attachment 446216] Patch v1.1

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 233935: [Cocoa] Web Inspector: provide a way for _WKInspectorExtension
clients to be to notified when an extension tab navigates
https://bugs.webkit.org/show_bug.cgi?id=233935

Attachment 446216: Patch v1.1

https://bugs.webkit.org/attachment.cgi?id=446216&action=review




--- Comment #6 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 446216
  --> https://bugs.webkit.org/attachment.cgi?id=446216
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=446216&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:9
> +	   * UserInterface/Views/WebInspectorExtensionTabContentView.js:

Can you add the reason `_frameContentDidLoad` is no longer necessary?

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionDelegate.h:58
> + * @abstract Called when a tab associated with this extension has navigated
to a new URL.
> + * @param tabIdentifier Identifier for the tab that navigated.
> + * @param URL The new URL for the extension tab's page.

Nit: missing `@param extension`. Also missing below on :63-64 if you feel like
fixing that in a drive-by here.