[webkit-reviews] review denied: [Bug 233821] [libpas] make build.sh, test.sh, build_and_test.sh, and clean.sh work on Linux : [Attachment 446008] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Zan Dobersek <zan at falconsigh.net>'s
request for review:
Bug 233821: [libpas] make build.sh, test.sh, build_and_test.sh, and clean.sh
work on Linux
https://bugs.webkit.org/show_bug.cgi?id=233821

Attachment 446008: Patch

https://bugs.webkit.org/attachment.cgi?id=446008&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 446008
  --> https://bugs.webkit.org/attachment.cgi?id=446008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446008&action=review

Thank you for doing this!  I just think that build_variant, in its current
form, would break us.

> Source/bmalloc/libpas/build.sh:98
> +    case $sdk in
> +	   macosx.internal)
> +	       build_variant_xcodebuild $@
> +	       ;;
> +    esac

This isn't adequate for us - we can have $sdk be:

- macosx
- macosx.internal
- iphoneos
- iphoneos.internal
- maybe other things too, but definitely not Linux ;-)

Also, the build_variant_linux seems like it would probably work on other
non-Xcode systems, so "Linux" might be a bad name.

What if you set $sdk to "cmake" instead of "linux" and this was just "case $sdk
in cmake) build_variant_cmake ;; *) build_variant_xcodebuild esac" or something
like that?