[webkit-reviews] review granted: [Bug 233900] Reload web views when toggling the captive portal mode at system level : [Attachment 446096] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 6 16:42:01 PST 2021


Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 233900: Reload web views when toggling the captive portal mode at system
level
https://bugs.webkit.org/show_bug.cgi?id=233900

Attachment 446096: Patch

https://bugs.webkit.org/attachment.cgi?id=446096&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 446096
  --> https://bugs.webkit.org/attachment.cgi?id=446096
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446096&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:979
> +	       page->reload({ });

Is the 'reload' process smart enough to handle cases where something is
opted-out?


More information about the webkit-reviews mailing list