[webkit-reviews] review granted: [Bug 232705] [GPU Process] [Filters 17/23] Make FilterEffect calculate the primitive subregion only when needed : [Attachment 446074] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 6 15:35:26 PST 2021


Cameron McCormack (:heycam) <heycam at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 232705: [GPU Process] [Filters 17/23] Make FilterEffect calculate the
primitive subregion only when needed
https://bugs.webkit.org/show_bug.cgi?id=232705

Attachment 446074: Patch

https://bugs.webkit.org/attachment.cgi?id=446074&action=review




--- Comment #13 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 446074
  --> https://bugs.webkit.org/attachment.cgi?id=446074
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446074&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:52
> +	   for (auto& input : inputs)
> +	       primitiveSubregion.unite(input->primitiveSubregion());

I guess we're guaranteed that input's primitive subregion has already been
calculated at this point, because of the ordering of the filter effects in the
overall expression?


More information about the webkit-reviews mailing list