[webkit-reviews] review granted: [Bug 233864] webpushd/webpushtool debugging additions : [Attachment 445994] Patch v1

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 233864: webpushd/webpushtool debugging additions
https://bugs.webkit.org/show_bug.cgi?id=233864

Attachment 445994: Patch v1

https://bugs.webkit.org/attachment.cgi?id=445994&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 445994
  --> https://bugs.webkit.org/attachment.cgi?id=445994
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=445994&action=review

> Source/WebKit/ChangeLog:14
> +	   * WebKit.xcodeproj/xcshareddata/xcschemes/webpushd.xcscheme: Added.

why?

> Source/WebKit/webpushd/PushClientConnection.mm:115
> +	   messageIdentifier = makeString ("[(0x",
hex((uint64_t)(m_xpcConnection.get()), WTF::HexConversionMode::Lowercase), ")]
");

reinterpret_cast

> Source/WebKit/webpushd/PushClientConnection.mm:117
> +	   messageIdentifier = makeString ("[", signingIdentifer, " (0x",
hex((uint64_t)(m_xpcConnection.get()), WTF::HexConversionMode::Lowercase), ")]
");

ditto

> Source/WebKit/webpushd/WebPushDaemon.mm:184
> +    broadcastDebugMessage((JSC::MessageLevel)0, makeString("New connection:
0x", hex((uint64_t)connection, WTF::HexConversionMode::Lowercase)));

JSC::MessageLevel::Log

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:39
> +enum class PreferTestService {

: bool

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:44
> +enum class Reconnect {

: bool