[webkit-reviews] review granted: [Bug 202142] Fix ServiceWorker downloads : [Attachment 446033] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 202142: Fix ServiceWorker downloads
https://bugs.webkit.org/show_bug.cgi?id=202142

Attachment 446033: Patch

https://bugs.webkit.org/attachment.cgi?id=446033&action=review




--- Comment #31 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 446033
  --> https://bugs.webkit.org/attachment.cgi?id=446033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446033&action=review

r=me

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:306
> +    SWFETCH_RELEASE_LOG("cancelFromClient:%d", m_isDone);

We should probably the logging better, it is really not obvious what %d is for.

SWFETCH_RELEASE_LOG("cancelFromClient: m_isDone=%d", m_isDone);

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:434
> +    // FIXME: We might want to keep the service worker alive until the
download ends.

Probably.

>
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:2
02
> +    auto iterator =
m_ongoingDownloads.find(makeObjectIdentifier<FetchIdentifierType>(decoder.desti
nationID()));

I think this would look nicer (more concise):
```
if (auto download =
m_ongoingDownloads.get(makeObjectIdentifier<FetchIdentifierType>(decoder.destin
ationID()))
    download->didReceiveMessage(connection, decoder);
```

> Source/WebKit/Scripts/generate-unified-sources.sh:17
> +UnifiedSourceCppFileCount=112

What is this for? Why is it included in this patch?