[webkit-reviews] review granted: [Bug 233850] [LFC][IFC] Compute isFirstBox/isLastBox for text content : [Attachment 445956] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 233850: [LFC][IFC] Compute isFirstBox/isLastBox for text content
https://bugs.webkit.org/show_bug.cgi?id=233850

Attachment 445956: Patch

https://bugs.webkit.org/attachment.cgi?id=445956&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 445956
  --> https://bugs.webkit.org/attachment.cgi?id=445956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445956&action=review

>
Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
:394
> +	   enum class LineHasFirstLastRunForTextBox { No, FirstOnly, LastOnly,
Both };

Don't you have a few types for this already like IsFirstLastBox and
OptionSet<InlineDisplay::Box::PositionWithinInlineLevelBox>?