[webkit-reviews] review granted: [Bug 233843] [GPU Process] (REGRESSION r285597): Fix SVGFilter clamping calculation : [Attachment 445933] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 233843: [GPU Process] (REGRESSION r285597): Fix SVGFilter clamping
calculation
https://bugs.webkit.org/show_bug.cgi?id=233843

Attachment 445933: Patch

https://bugs.webkit.org/attachment.cgi?id=445933&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 445933
  --> https://bugs.webkit.org/attachment.cgi?id=445933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445933&action=review

> Source/WebCore/rendering/CSSFilter.h:53
> +    RefPtr<FilterEffect> lastEffect() const override;

or final?

> Source/WebCore/svg/graphics/filters/SVGFilter.h:45
> +    RefPtr<FilterEffect> lastEffect() const override { return
!m_expression.isEmpty() ? m_expression.last() : nullptr; }

final