[webkit-reviews] review granted: [Bug 233837] [ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables : [Attachment 445891] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 233837: [ANGLE] clang with -Wunknown-warning-option will fail on
-Wweak-template-vtables
https://bugs.webkit.org/show_bug.cgi?id=233837

Attachment 445891: Patch

https://bugs.webkit.org/attachment.cgi?id=445891&action=review




--- Comment #3 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 445891
  --> https://bugs.webkit.org/attachment.cgi?id=445891
Patch

Looks fine, though please keep in mind this will collide with the big ANGLE
upgrade Kyle's in the middle of in Bug 220896. Unless this is really pressing
it might be better to wait for that to complete, but not sure how many blockers
there are on that. r+