[webkit-reviews] review granted: [Bug 233819] CSS animation sorting may crash due to AnimationList copy upon CSS Animation removal : [Attachment 445868] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 233819: CSS animation sorting may crash due to AnimationList copy upon CSS
Animation removal
https://bugs.webkit.org/show_bug.cgi?id=233819

Attachment 445868: Patch

https://bugs.webkit.org/attachment.cgi?id=445868&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 445868
  --> https://bugs.webkit.org/attachment.cgi?id=445868
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445868&action=review

> Source/WebCore/ChangeLog:52
> +

When the ChangeLog is much bigger than the change.

> Source/WebCore/platform/animation/AnimationList.h:39
> +    Ref<AnimationList> copy(CopyAnimations copyAnimations =
CopyAnimations::Yes) const { return adoptRef(*new AnimationList(*this,
copyAnimations)); }

It seems weird that you could have copy(CopyAnimations::No) - until you realise
you're talking about the members of the list. So maybe it should be called
CopyAnimationMembers? Or flip it and call it Clone? I don't know. It's just a
bit confusing.