[webkit-reviews] review granted: [Bug 233798] Add API test for Bug 233783 : [Attachment 445863] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 233798: Add API test for Bug 233783
https://bugs.webkit.org/show_bug.cgi?id=233798

Attachment 445863: Patch

https://bugs.webkit.org/attachment.cgi?id=445863&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 445863
  --> https://bugs.webkit.org/attachment.cgi?id=445863
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445863&action=review

> Source/WebKit/ChangeLog:3
> +	   Add API test for Bug 233783

Looks like you found something additional to fix in ProvisionalPageProxy, so
this is not just adding a test any more. Is that correct? Should we retitle?

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:419
> +- (void)_isLayerTreeFrozen:(void (^)(BOOL frozen))completionHandler
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

Why did you decide to put this into Private rather than PrivateForTesting?