[webkit-reviews] review denied: [Bug 233798] Add API test for Bug 233783 : [Attachment 445857] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 233798: Add API test for Bug 233783
https://bugs.webkit.org/show_bug.cgi?id=233798

Attachment 445857: Patch

https://bugs.webkit.org/attachment.cgi?id=445857&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 445857
  --> https://bugs.webkit.org/attachment.cgi?id=445857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445857&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:419
> +- (void)_isLayerTreeFrozen:(void (^)(BOOL frozen))completionHandler;

availability macros, WKWebViewPrivateForTesting.h

> Source/WebKit/WebProcess/WebPage/WebPage.messages.in:405
> +    isLayerTreeFrozenForTesting() -> (bool isFrozen) Async

The freezing isn't for testing, the query is.  I'm not sure if the naming could
be more clear.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7275
> +    sourceHeaders.add("Content-Type"_s, "text/html"_s);

These can be put in the initializer list.  That would clean up the syntax a
lot.