[webkit-reviews] review granted: [Bug 233782] [libpas] Update to 96f9f4c28dc119695311c7c6bd81ed1f3f4e260c (allow more specialization of partial versus exclusive allocation) : [Attachment 445769] the patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 233782: [libpas] Update to 96f9f4c28dc119695311c7c6bd81ed1f3f4e260c (allow
more specialization of partial versus exclusive allocation)
https://bugs.webkit.org/show_bug.cgi?id=233782

Attachment 445769: the patch

https://bugs.webkit.org/attachment.cgi?id=445769&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 445769
  --> https://bugs.webkit.org/attachment.cgi?id=445769
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445769&action=review

r=me
Can you add new files to bmalloc/CMakeLists.txt too?

> Source/bmalloc/ChangeLog:14
> +	   of the same megapages, so a megapage lookup could not tell you if
you were explicit or shared.

explicit => exclusive?

> Source/bmalloc/ChangeLog:17
> +	   explicit and shared, and spreads it across all page management
logic. So:

Ditto.

> Source/bmalloc/ChangeLog:20
> +	   -> Page allocation knows the page's role, so it can use different
megapages for explicit or shared. This
> +	      enables explicit and shared to have different deallocation fast
paths.

Ditto.

> Source/bmalloc/ChangeLog:22
> +	   -> Page_kind is now different depending on whether the page is
explicit or shared.

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_local_allocator.c:62
> +	   PAS_ASSERT(pas_is_aligned(allocator->object_size,
pas_local_allocator_alignment(allocator)));

Should we move this to the subsequent
`pas_segregated_size_directory_is_bitfit(directory)`'s else branch?