[webkit-reviews] review granted: [Bug 233789] Introduce a MainThreadBridge class inside WebLockManager : [Attachment 445786] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 233789: Introduce a MainThreadBridge class inside WebLockManager
https://bugs.webkit.org/show_bug.cgi?id=233789

Attachment 445786: Patch

https://bugs.webkit.org/attachment.cgi?id=445786&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 445786
  --> https://bugs.webkit.org/attachment.cgi?id=445786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445786&action=review

> Source/WebCore/Modules/web-locks/WebLockManager.cpp:68
> +class WebLockManager::MainThreadBridge : public
ThreadSafeRefCounted<MainThreadBridge, WTF::DestructionThread::Main> {

Are we reference counting this just for the "destroy on main thread" bit?
Because if so, I suggest we instead use unique_ptr and null it out on the main
thread in ~WebLockManager. I don’t see any ref/deref of this going on.