[webkit-reviews] review granted: [Bug 233293] Web Inspector: Web Inspector^2 crashes after closing if Web Inspector^1 closed first : [Attachment 445788] Patch v1.1 (for landing)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 16:36:29 PST 2021


Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 233293: Web Inspector: Web Inspector^2 crashes after closing if Web
Inspector^1 closed first
https://bugs.webkit.org/show_bug.cgi?id=233293

Attachment 445788: Patch v1.1 (for landing)

https://bugs.webkit.org/attachment.cgi?id=445788&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 445788
  --> https://bugs.webkit.org/attachment.cgi?id=445788
Patch v1.1 (for landing)

View in context: https://bugs.webkit.org/attachment.cgi?id=445788&action=review

r=me, nice! =D

> Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:424
> +   
m_inspectorPage->process().addMessageReceiver(Messages::WebInspectorUIProxy::me
ssageReceiverName(), m_inspectedPageIdentifier, *this);

please see comment #5 :)


More information about the webkit-reviews mailing list