[webkit-reviews] review granted: [Bug 233764] Make enum values consistent in ApplicationManifest::Icon::Purpose and _WKApplicationManifestIconPurpose : [Attachment 445778] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 15:16:26 PST 2021


Brent Fulgham <bfulgham at webkit.org> has granted rginsberg at apple.com's request
for review:
Bug 233764: Make enum values consistent in ApplicationManifest::Icon::Purpose
and _WKApplicationManifestIconPurpose
https://bugs.webkit.org/show_bug.cgi?id=233764

Attachment 445778: Patch

https://bugs.webkit.org/attachment.cgi?id=445778&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 445778
  --> https://bugs.webkit.org/attachment.cgi?id=445778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445778&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:48
> +    _WKApplicationManifestIconPurposeMaskable = (1 << 2),

Thank you for adjusting this!


More information about the webkit-reviews mailing list