[webkit-reviews] review denied: [Bug 233764] Make enum values consistent in ApplicationManifest::Icon::Purpose and _WKApplicationManifestIconPurpose : [Attachment 445744] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied rginsberg at apple.com's request
for review:
Bug 233764: Make enum values consistent in ApplicationManifest::Icon::Purpose
and _WKApplicationManifestIconPurpose
https://bugs.webkit.org/show_bug.cgi?id=233764

Attachment 445744: Patch

https://bugs.webkit.org/attachment.cgi?id=445744&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 445744
  --> https://bugs.webkit.org/attachment.cgi?id=445744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445744&action=review

This looks fine, but I suggest following the model of the underling WebCore
type and use the bitwise-shift to show the mask values.

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:46
> +    _WKApplicationManifestIconPurposeAny = 1,

We should follow the behavior of the
WebCore::ApplicationManifest::Icon::Purpose enum:

_WKApplicationManifestIconPurposeAny =	(1 << 0),

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:47
> +    _WKApplicationManifestIconPurposeMonochrome = 2,

_WKApplicationManifestIconPurposeMonochrome = (1 << 1),

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:48
> +    _WKApplicationManifestIconPurposeMaskable = 4,

_WKApplicationManifestIconPurposeMaskable = (1 << 2),