[webkit-reviews] review granted: [Bug 233698] Persist NavigationPreloadState in service worker registration database : [Attachment 445691] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 233698: Persist NavigationPreloadState in service worker registration
database
https://bugs.webkit.org/show_bug.cgi?id=233698

Attachment 445691: Patch

https://bugs.webkit.org/attachment.cgi?id=445691&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 445691
  --> https://bugs.webkit.org/attachment.cgi?id=445691
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445691&action=review

> Source/WebCore/workers/service/NavigationPreloadState.h:36
> +    static NavigationPreloadState defaultValue() { return { false, "true"_s
}; }

Maybe we should do `String headerValue { "true"_s };` below and use the default
constructor instead of this defaultValue()? Or do we need to distinguish
default-constructed objects somehow?

> Source/WebCore/workers/service/server/RegistrationStore.h:43
> +struct NavigationPreloadState;

Seems unnecessary? It isn't used in this header.