[webkit-reviews] review granted: [Bug 232454] AVDelegatingPlaybackCoordinator error compiling on macOS 11 : [Attachment 445672] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 23:29:33 PST 2021


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 232454: AVDelegatingPlaybackCoordinator error compiling on macOS 11
https://bugs.webkit.org/show_bug.cgi?id=232454

Attachment 445672: Patch

https://bugs.webkit.org/attachment.cgi?id=445672&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 445672
  --> https://bugs.webkit.org/attachment.cgi?id=445672
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445672&action=review

> Source/WTF/wtf/PlatformHave.h:1100
> +#define HAVE_DELEGATING_PLAYBACK_COORDINATOR 1

I would go with HAVE_AV_DELEGATING_PLAYBACK_COORDINATOR. Also you don't need
review for this kind of stuff

> Source/WebCore/PAL/ChangeLog:8
> +	   * pal/cocoa/AVFoundationSoftLink.h: Don't softlink on platforms that
don't have it

Weird? What about AT LEAST the SOFT_LINK_CLASS_FOR_SOURCE?


More information about the webkit-reviews mailing list