[webkit-reviews] review granted: [Bug 233691] [WebGPU] Add default values to structs in WebCore/Modules/WebGPU : [Attachment 445539] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 14:55:07 PST 2021


Alex Christensen <achristensen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 233691: [WebGPU] Add default values to structs in WebCore/Modules/WebGPU
https://bugs.webkit.org/show_bug.cgi?id=233691

Attachment 445539: Patch

https://bugs.webkit.org/attachment.cgi?id=445539&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 445539
  --> https://bugs.webkit.org/attachment.cgi?id=445539
Patch

Definitely an improvement.  I'm still concerned about all those raw pointers. 
Can they be WeakPtr instead?


More information about the webkit-reviews mailing list