[webkit-reviews] review granted: [Bug 233723] Remove StructureIDBlob : [Attachment 445609] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 233723: Remove StructureIDBlob
https://bugs.webkit.org/show_bug.cgi?id=233723

Attachment 445609: Patch

https://bugs.webkit.org/attachment.cgi?id=445609&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 445609
  --> https://bugs.webkit.org/attachment.cgi?id=445609
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445609&action=review

r=me

> Source/JavaScriptCore/runtime/Structure.h:861
> +    // part of the object. And need to match the order of the equivalent
properties in
> +    // JSCell.
> +    IndexingType m_indexingModeIncludingHistory;
> +    JSType m_type;
> +    TypeInfo::InlineTypeFlags m_inlineTypeFlags;
> +    CellState m_defaultCellState { CellState::DefinitelyWhite };

I think we should rename them to explicitly state that they are information of
JSCell allocated with this Structure.
Since Structure itself is a JSCell, it has Structure::m_type etc. in JSCell
parent class. So using the same name here is confusing.
e.g. m_instanceType, m_instanceIndexingModeIncludingHistory etc.